• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5041: Clickable map not working with SSL links

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension TWikiDrawPlugin Normal No Action Required   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Test case:

I do not have the environment to test it out but I looked through the code. The map data is created by calling the getMap method of src/CH/ifa/draw/contrib/PolygonFigure.java, src/CH/ifa/draw/figures/EllipseFigure.java, src/CH/ifa/draw/figures/PolyLineFigure.java, src/CH/ifa/draw/figures/RectangleFigure.java, and src/CH/ifa/draw/figures/RoundRectangleFigure.java. That method calls URLDecoder.decode() on the user entered URL. It is the only call in a try catch block, e.g. the only place where this can fail. I could confirm it by adding an https link to an arrow tip, which does not call URLDecoder.decode(). I do not know why this call is needed, I think it should be removed because it actually decodes URL, e.g. changes pluses to spaces, which breaks URLs apart.

Since I do not have the environment, could someone fix that by removing:

        try {
        sense = URLDecoder.decode(sense);
        } catch (Exception e) {}

from the above mentioned getMap methods, and rebuild the jar file?

-- TWiki:Main.PeterThoeny - 27 Nov 2007

False alarm, although it is a confusing usability issue. When you add a URL to a box that has already a string in it you might attach the URL to the string instead of the box, depending where you click inside the box. I fixed the drawing by deleting all URLs and re-attaching them to the boxes instead of the strings.

-- TWiki:Main.PeterThoeny - 27 Nov 2007

ItemTemplate
Summary Clickable map not working with SSL links
ReportedBy TWiki:Main.PeterThoeny
Codebase 4.1.2
SVN Range TWiki-4.3.0, Sun, 25 Nov 2007, build 15790
AppliesTo Extension
Component TWikiDrawPlugin
Priority Normal
CurrentState No Action Required
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2007-11-27 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback