• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5049: Some columns turn into mutli-span when using EditRowPlugin

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension EditRowPlugin Normal No Action Required   minor  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

When I add a row, and there is a column defined as "text", "text area", or "date" next to any other column, if you don't fill in that column, than that column gets eaten by the column before as a mult-span column, which is incorrect.

To Duplicate Error:

Add a row, save. Notice that some columns turn into mutli-span.

I should get this:


| Nr | Text | Step | Radio | Text Area | Date |
|  4 | |  one |  :-) | | |
| 5 |  test | one |  :-) |  test | |
| 6 | | one |  :-) | |  29 November 2007 |
| 7 | | one |  :-) | | |
| 8 | | one | :-) | | |

Instead I get this:

| Nr | Text | Step | Radio | Text Area | Date |
|  4 | |  one |  :-) | | |
| 5 |  test | one |  :-) |  test | |
| 6 | | one |  :-) | |  29 November 2007 |
| 7 | | one |  :-) | | |
| 8 || one | :-) |||

There's a subtlety here that might trap the unwary.

An empty cell in a TWiki table is interpreted as an extension of a prior multicol cell. The plugin is consistent with this; if you don't provide a value for a cell, then it collapses it into a prior column. TWiki tables support cells that have no data as well, namely cells that contain just whitespace. Again, the plugin is consistent; it treats a cell that contains just whitespace as a value placeholder. The EditTablePlugin is inconsistent, because it always saves cells with whitespace, even when the cell had no whitespace when the edit started. Note that when you edit, all cells appear in the edit even when multicol cells are in use.

The tradeofff is between supporting multicol cells, and 100% consistency with EditTablePlugin. I think on balance that the EditRowPlugin does it right and EditTablePlugin is wrong. Both plugins can open a table containing colspans, but only EditRowPlugin will save it correctly. No action.

CC

ItemTemplate
Summary Some columns turn into mutli-span when using EditRowPlugin
ReportedBy TWiki:Main.PaulineCheung
Codebase

SVN Range TWiki-4.3.0, Sun, 25 Nov 2007, build 15790
AppliesTo Extension
Component EditRowPlugin
Priority Normal
CurrentState No Action Required
WaitingFor

Checkins

TargetRelease minor
ReleasedIn

Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2007-12-13 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback