• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
UpgradeTwiki writes a LocalSite.cfg containing all config parameters which have changed against their defaults, but erroneously takes Cairo and not Dakar defaults.

In Dakar's TWiki.pm, PubUrlPath and ScriptUrlPath are explicitly set to a bogus default "NOT SET", whereas TWiki/Upgrade/TWikicfg.pm compares against the Cairo defaults of /twiki/pub and /twiki/bin, respectively.

Since the URLs are a matter of web server configuration and not TWiki upgrade, I'd suggest to write them explicitly to LocalSite.cfg regardless of their Cairo values (by setting the assumed default values to undef):

--- TWikiCfg.pm.orig    2005-09-26 13:50:33.350383200 +0200
+++ TWikiCfg.pm 2005-09-27 12:58:53.396238300 +0200
@@ -105,9 +105,9 @@
     print CFG old2new($defaultUrlHost, "http://your.domain.com",
                       "{DefaultUrlHost}", 1 );
-    print CFG old2new($scriptUrlPath, "/twiki/bin",
+    print CFG old2new($scriptUrlPath, undef,
                       "{ScriptUrlPath}", 1 );
     print CFG old2new($dispScriptUrlPath, "/twiki/bin",
                       "{DispScriptUrlPath}", 0 );
-    print CFG old2new($pubUrlPath, "/twiki/pub",
+    print CFG old2new($pubUrlPath, undef,
                       "{PubUrlPath}" );
     print CFG old2new($dataDir, "/home/httpd/twiki/data",

Ahm... I should note that this patch is untested right now.


The assumption during upgrade is that the upgraded TWiki is going to be operating under the same URLs as the original Cairo, so it is correct for it to use the Cairo values in the typical cases. It will get it right as many times as it gets it wrong. The only way to resolve this would be interactively, and I debate if it is worthwhile trying to do that at this late stage.

CC


The assumption is all ok - but UpgradeTwiki and TWiki.pm don't agree what the "defaults" are!

Let me try to explain it in some detail:

  • In Cairo, I have PubUrlPath and ScriptUrlPath set to /twiki/pub and /twiki/bin, their respective Cairo defaults.
  • UpgradeTwiki (in TWikiCfg.pm) finds that PubUrlPath and ScriptUrlPath are still set to Cairo defaults (which are hardwired in TWikiCfg.pm), therefore does not write them to LocalSite.cfg.
  • TWiki.pm does not find values for PubUrlPath and ScriptUrlPath and defaults them to 'NOT SET' which breaks links.

Of course everything is fine once I run configure, which initializes the URL paths from its own URL. And I agree that interactive resolution is no good idea. I just hoped that UpgradeTwiki would get it right from the start. Dakar ought to use the Cairo values if possible. But to get there it should either have the same default values for PubUrlPath and ScriptUrlPath, or the upgrade tool should omit them from LocalSite.cfg only if they match Dakar defaults. The patch I suggested is doing the latter, though one could as well keep the default values for PubUrlPath and ScriptUrlPath in TWiki.cfg.

-- TWiki:Main.HaraldJoerg

Undeferred, post Dakar CC


By this time, either everyone has upgraded or their not going to. Given the pressure of other more critical requirements, i'm dropping this.

CC

ItemTemplate
Summary Dakar Beta: scriptUrlPath defaults missing after UpgradeTwiki
ReportedBy TWiki:Main.HaraldJoerg
Codebase

SVN Range

AppliesTo Engine
Component BuildScripts
Priority Low
CurrentState No Action Required
WaitingFor

Checkins

TargetRelease major
ReleasedIn

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2007-02-03 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback