• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

The user gets no mail if you disable the verification within configure script.


hm, i think that's by design. please be more specific. which emails aren't getting sent? a welcome message? WebNotify? which email are you expecting? more DETAILS please. -- WN


Well, I haven't been asked but can provide details on this case...

Even if I have {Register}{NeedVerification} set to false, I would expect that the registering user and the administrator would receive the "final" mail (the "Thank you for registering" and "This is an automated email notification of user registration in TWiki." thingies). The oops page I get after registering reads " A confirmation e-mail has been sent to my@mail.address" However, this doesn't happen.

The reason is that in lib/TWiki/UI/Register.pm the routine _emailRegistrationConfirmations( $session, $data ); is called from verifyEmailAddress instead of from finish.

The patch I'm attaching fixes this issue by simply moving the call, but has an important side effect: The mail to the user does no longer contain his password. To be honest, I would more than happy with this, given the recent discussion about Item593....

-- TWiki:Main.HaraldJoerg

Yup, perfect diagnosis.

C:\moreprgs\indigoperl\apache\TWiki\lib\TWiki\UI>svn commit -m "Item516: variant on HaraldJoerg's fine patch, this should email the password still" Register.pm

I altered it slightly:

+    # inform user and admin about the registration. Note: do it now before
+    # purgeKeys deletes the password.
+    _emailRegistrationConfirmations( $session, $data );
     my $log = _newUserFromTemplate($session, 'NewUserTemplate', $data);

     my $success = _addUserToPasswordSystem( $session, $data );

sven@sven:/usr/lib/cgi-bin/DEVELOP/lib/TWiki/UI$ svn log Register.pm
------------------------------------------------------------------------
r6811 | MartinCleaver | 2005-10-07 13:44:27 +0200 (Fri, 07 Oct 2005) | 1 line

Item516: variant on HaraldJoerg's fine patch, this should email the password still


-- MC

Harald, thanks for your fast reply on this! Had to shift this task a litle bit.

-- AU

Thanks to Harald...

svn commit -m "Item516: Testcase with NeedVerification switched off" test/unit/RegisterTests.pm Sending test/unit/RegisterTests.pm Transmitting file data . Committed revision 7343.

-- MC

ItemTemplate
Summary No email gets sent if {Register}{NeedVerification} mode is disabled
ReportedBy AndreUlrich
AppliesTo Engine
Priority Urgent
CurrentState Closed
WaitingFor

Checkins 6811 7343
Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatdiff Register.pm.Item516.diff r0 manage 0.7 K 2005-10-07 - 11:15 HaraldJoerg Move call of _emailRegistrationConfirmations( $session, $data ); to finish()
Edit | Attach | Watch | Print version | History: r13 < r12 < r11 < r10 < r9 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r13 - 2005-11-06 - MartinCleaver
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback