The user gets no mail if you disable the verification within configure script.
hm, i think that's by design. please be more specific. which emails aren't getting sent? a welcome message?
WebNotify? which email are you expecting? more DETAILS please. --
WN
Well, I haven't been asked but can provide details on this case...
Even if I have
{Register}{NeedVerification}
set to false, I would expect that the registering user and the administrator would receive the "final" mail (the "Thank you for registering" and "This is an automated email notification of user registration in TWiki." thingies). The oops page I get after registering reads " A confirmation e-mail has been sent to
my@mail.address" However, this doesn't happen.
The reason is that in
lib/TWiki/UI/Register.pm
the routine
_emailRegistrationConfirmations( $session, $data );
is called from
verifyEmailAddress
instead of from
finish
.
The patch I'm attaching fixes this issue by simply moving the call, but has an important side effect: The mail to the user does no longer contain his password. To be honest, I would more than happy with this, given the recent discussion about
Item593....
--
TWiki:Main.HaraldJoerg
Yup, perfect diagnosis.
C:\moreprgs\indigoperl\apache\TWiki\lib\TWiki\UI>svn commit -m "Item516: variant on
HaraldJoerg's fine patch, this should email the password still" Register.pm
I altered it slightly:
+ # inform user and admin about the registration. Note: do it now before
+ # purgeKeys deletes the password.
+ _emailRegistrationConfirmations( $session, $data );
my $log = _newUserFromTemplate($session, 'NewUserTemplate', $data);
my $success = _addUserToPasswordSystem( $session, $data );
sven@sven:/usr/lib/cgi-bin/DEVELOP/lib/TWiki/UI$ svn log Register.pm
------------------------------------------------------------------------
r6811 | MartinCleaver | 2005-10-07 13:44:27 +0200 (Fri, 07 Oct 2005) | 1 line
Item516: variant on HaraldJoerg's fine patch, this should email the password still
--
MC
Harald, thanks for your fast reply on this! Had to shift this task a litle bit.
--
AU
Thanks to Harald...
svn commit -m "Item516: Testcase with
NeedVerification switched off" test/unit/RegisterTests.pm
Sending test/unit/RegisterTests.pm
Transmitting file data .
Committed revision 7343.
--
MC