Item5387: Issue with multi-span rows and the EditRowPlugin / TablePlugin

Example:

%EDITTABLE{ headerrows="1" format="| text, 40 | text, 15 | text, 25 | text, 25 | text, 25 |" }%
|*Decription*|*Part Number*|*WR server*|*Speedera*|*WR server*|
| Obi is super cute | tail | alameda | 1 | twiki.wrs.com|
|^| eyes | alameda | 1 |^|
| Birds are fabulous |^|sunnyvale|5|ala-engtools-dev|
 

-- TWiki:Main/PaulineCheung - 23 Feb 2008

Do you mean rowspan or column span? I don't see either type in the first row of your example....

CC

After an IM conversation with Pauline I understand the problem now. Confirmed.

OK, I understand the cause. The plugin adds an invisible HTML anchor to the first colum to allow table navigation, but the TablePlugin doesn't tolerate any other content in the marked cell. This means it is impossible to put an anchor (or any other invisible HTML) in a table row that consists only of rowspans. For that reason I'm passing this problem on to TablePlugin, which needs to apply the following trivial patch to allow ^ to coexist with HTML:

===================================================================
--- lib/TWiki/Plugins/TablePlugin/Core.pm    (revision 16418)
+++ lib/TWiki/Plugins/TablePlugin/Core.pm    (working copy)
@@ -616,7 +616,7 @@
             $attr->{width} = $columnWidths[$colCount];
         }
 
-        if (/^\s*\^\s*$/) {    # row span above
+        if (/^(\s|<[^>]*>)*\^(\s|<[^>]*>)*$/) {    # row span above
             $rowspan[$colCount]++;
             push @row, { text => $value, type => 'Y' };
         }

CC

Fixed in trunk and uploaded to TWiki.org. Will need to be merged to patch branch.

CC

Thanks for the bug fix.

A detail. Do not close until merged. There is no way we can find these unmerged bugs again once it is "below the fold".

I have merged now.

KJL