• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5435: Thumbnail sizes not honouring either Preference setting or hard coded defaults

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension ImagePlugin Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Whilst upgrading my TWiki installation from 4.1.2 to 4.2.0, and thus all my Plugins, I discovered that ImagePlugin no longer produces smaller images for thumbnails.

Upgrading my existing 4.1.2 with the new version produced the same result: thumbnails are no longer thumb sized. (Alas, when I upgraded, I also overwrote my copy of the original, and can be no longer sure what version i had that worked... duh! From memory, it was the version that listed changes at the 18 Dec 2006, but not 03 Jan 2008.)

Having checked the code whilst trying to set a default, I also note that the documentation refers to a variable IMGPLUGIN_THUMBNAIL, but the code seems to be trying to find THUMBNAIL_SIZE. (Needless to say, when it doesn't find it overridden, the default of 180 is not applied either.)

-- TWiki:Main/ScottClaridge - 13 Mar 2008

Possible Fix: There seems to be a bug in version 1.0 of ImagePlugin/Core.pm as described. If you remove the following line (line 431) in the parseWikipediaParams sub, it seems to work:

return unless $argStr =~ /\|/g

At the bottom of the sub, it calculates the size of the thumbnail which is skipped if the above line is not removed. I'm not sure what else it breaks - someone else might like to investigate further wink

-- TWiki:Main.BrettSchlock - 13 May 2008

I moved up validating the type argument in the calling function.

-- TWiki:Main.MichaelDaum - 03 Jul 2008

ItemTemplate
Summary Thumbnail sizes not honouring either Preference setting or hard coded defaults
ReportedBy TWiki:Main.ScottClaridge
Codebase 4.1.2, 4.2.0
SVN Range TWiki-5.0.0, Sun, 09 Mar 2008, build 16496
AppliesTo Extension
Component ImagePlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:16975 TWikirev:16981
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2008-07-04 - MichaelDaum
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback