• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5466: default and classic search.tmpl's have one table per topic result

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   patch 4.2.1, 5.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

extremely odd, and presumably unintended

Its a simple fix to make it consistent with pattern skin

-- TWiki:Main/SvenDowideit - 23 Mar 2008

something like:

Index: templates/search.tmpl
===================================================================
--- templates/search.tmpl   (revision 81)
+++ templates/search.tmpl   (working copy)
@@ -12,13 +12,14 @@
 %TMPL:DEF{"searchbody"}%%SPLIT%%TMPL:P{"repeatedsearchblock"}%
 %SPLIT%Number of topics: <b>%NTOPICS%</b>%TMPL:END%
 
-%TMPL:DEF{"repeatedsearchblock"}%%TABLE%<table width="100%" border="0" cellpadding="0" cellspacing="4">
+%TMPL:DEF{"repeatedsearchblock"}%
+%TABLE%<table width="100%" border="0" cellpadding="0" cellspacing="4">
    <tr bgcolor="%WEBBGCOLOR%">
       <td width="50%"><b>%MAKETEXT{"Topics in [_1] web" args="<nop>%WEB%"}%</b></td>
       <td width="30%"><b>%MAKETEXT{"Changed"}%</b></td>
       <td width="20%"><b>%MAKETEXT{"Changed by"}%</b></td>
    </tr>
-</table>%REPEAT%<table width="100%" border="0" cellspacing="0" cellpadding="0">
+%REPEAT%
    <tr>
       <td width="50%"><a href="%SCRIPTURLPATH{"view"}%/%WEB%/%TOPICNAME%"><b>%TOPICNAME%</b></a></td>
       <td width="30%"><a href="%SCRIPTURLPATH{"rdiff"}%/%WEB%/%TOPICNAME%" rel='nofollow'>%TIME%</a> - %REVISION%</td>
@@ -28,7 +29,7 @@
       <td colspan="2"><font size="-1">%TEXTHEAD%</font></td>
       <td width="20%">&nbsp;</td>
    </tr>
-</table>%REPEAT%<br clear="all" />%TMPL:END%
+%REPEAT%</table><br clear="all" />%TMPL:END%
 
 %TMPL:DEF{"content"}%%SPLIT%%MAKETEXT{"Searched:"}% <b> %SEARCHSTRING% </b>
 <p />%TMPL:P{"searchbody"}%<p />%SPLIT%%TMPL:P{"topicinfo"}%%TMPL:END%

-- TWiki:Main.SvenDowideit - 23 Mar 2008

and is completely broken for skin=text - see http://develop.twiki.org/~twiki4/cgi-bin/view/TWiki/WebSearch?search=context&scope=all;skin=text which shows the same results as I'm seeing in both trunk and TWikiRelease04x02 branches

-- TWiki:Main.SvenDowideit - 31 Mar 2008

ItemTemplate
Summary default and classic search.tmpl's have one table per topic result
ReportedBy TWiki:Main.SvenDowideit
Codebase 4.2.0, 4.2.1, ~twiki4
SVN Range TWiki-5.0.0, Sun, 09 Mar 2008, build 16496
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:16590 TWikirev:16591 TWikirev:16592 TWikirev:16593 TWikirev:16594 TWikirev:16595 TWikirev:16596 TWikirev:16597
TargetRelease patch
ReleasedIn 4.2.1, 5.0.0
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2008-08-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback