Item5595: EditRowPlugin Errors with Included Tables

When I try to save a change to an EditRowPlugin I get the following error:

TWiki detected an internal error - please check your TWiki logs and webserver logs for more information.  Can't use an undefined value as an ARRAY reference

I pasted the error message here:

| 30 Apr 2008 - 14:54 | Can't use an undefined value as an ARRAY reference at /twiki1/twiki/pcheung/lib/TWiki/Plugins/EditRowPlugin/Table.pm line 498.  at /twiki1/twiki/pcheung/lib/TWiki/Plugins/EditRowPlugin/Table.pm line 498  TWiki::Plugins::EditRowPlugin::Table::_getCols('TWiki::Plugins::EditRowPlugin::Table=HASH(0xa6aa4f4)', 'HASH(0xa6a83f4)', 3) called at /twiki1/twiki/pcheung/lib/TWiki/Plugins/EditRowPlugin/Table.pm line 534  TWiki::Plugins::EditRowPlugin::Table::change('TWiki::Plugins::EditRowPlugin::Table=HASH(0xa6aa4f4)', 'HASH(0xa6a83f4)') called at/twiki1/twiki/pcheung/lib/TWiki/Plugins/EditRowPlugin.pm line 286  TWiki::Plugins::EditRowPlugin::save('TWiki=HASH(0x964ad40)', 'EditRowPlugin', 'save') called at /twiki1/twiki/pcheung/lib/TWiki/Func.pm line 1785  TWiki::Func::__ANON__('TWiki=HASH(0x964ad40)', 'EditRowPlugin', 'save') called at /twiki1/twiki/pcheung/lib/TWiki/UI/Rest.pm line68  TWiki::UI::Rest::gateway('TWiki=HASH(0x964ad40)') called at /twiki1/twiki/pcheung/lib/TWiki/UI.pm line 109  TWiki::UI::__ANON__() called at /twiki1/twiki/pcheung/lib/CPAN/lib///Error.pm line 379  eval {...} called at /twiki1/twiki/pcheung/lib/CPAN/lib///Error.pm line 371  Error::subs::try('CODE(0xa66b598)', 'HASH(0xa66a320)') called at /twiki1/twiki/pcheung/lib/TWiki/UI.pm line 158  TWiki::UI::run('CODE(0x96619a4)') called  

I also got the following error when I was trying to do a row move.

TWiki detected an internal error - please check your TWiki logs and webserver logs for more information.  Can't call method "stringify" on an undefined value

| 30 Apr 2008 - 16:16 | Can't call method "stringify" on an undefined value at /twiki1/twiki/pcheung/lib/TWiki/Plugins/EditRowPlugin/Table.pm line 245.  at /twiki1/twiki/pcheung/lib/TWiki/Plugins/EditRowPlugin/Table.pm line 245  TWiki::Plugins::EditRowPlugin::Table::stringify('TWiki::Plugins::EditRowPlugin::Table=HASH(0xac48580)') called at /twiki1/twiki/pcheung/lib/TWiki/Plugins/EditRowPlugin.pm line 288  TWiki::Plugins::EditRowPlugin::save('TWiki=HASH(0x9be8d40)', 'EditRowPlugin', 'save') called at /twiki1/twiki/pcheung/lib/TWiki/Func.pm line 1785  TWiki::Func::__ANON__('TWiki=HASH(0x9be8d40)', 'EditRowPlugin', 'save') called at /twiki1/twiki/pcheung/lib/TWiki/UI/Rest.pm line68  TWiki::UI::Rest::gateway('TWiki=HASH(0x9be8d40)') called at /twiki1/twiki/pcheung/lib/TWiki/UI.pm line 109  TWiki::UI::__ANON__() called at /twiki1/twiki/pcheung/lib/CPAN/lib///Error.pm line 379  eval {...} called at /twiki1/twiki/pcheung/lib/CPAN/lib///Error.pm line 371  Error::subs::try('CODE(0xac09618)', 'HASH(0xac083a0)') called at /twiki1/twiki/pcheung/lib/TWiki/UI.pm line 158  TWiki::UI::run('CODE(0x9bff9a4)') called  

I also get the same error when I attempt to add rows

TWiki detected an internal error - please check your TWiki logs and webserver logs for more information.  Can't use an undefined value as an ARRAY reference 

| 09 May 2008 - 17:08 | Can't use an undefined value as an ARRAY reference at /twiki1/twiki/prod/lib/TWiki/Plugins/EditRowPlugin/Table.pm line 489.        TWiki::Plugins::EditRowPlugin::Table::_getCols('TWiki::Plugins::EditRowPlugin::Table=HASH(0x92d10f4)','HASH(0x92cd2b4)',4) called at /twiki1/twiki/prod/lib/TWiki/Plugins/EditRowPlugin/Table.pm line 525        TWiki::Plugins::EditRowPlugin::Table::change('TWiki::Plugins::EditRowPlugin::Table=HASH(0x92d10f4)','HASH(0x92cd2b4)') called at /twiki1/twiki/prod/lib/TWiki/Plugins/EditRowPlugin/Table.pm line 566        TWiki::Plugins::EditRowPlugin::Table::addRow('TWiki::Plugins::EditRowPlugin::Table=HASH(0x92d10f4)','HASH(0x92cd2b4)') called at /twiki1/twiki/prod/lib/TWiki/Plugins/EditRowPlugin.pm line 280        TWiki::Plugins::EditRowPlugin::save('TWiki=HASH(0x824bfcc)','EditRowPlugin','save') called at /twiki1/twiki/prod/lib/TWiki/Func.pm line 1785        TWiki::Func::__ANON__('TWiki=HASH(0x824bfcc)','EditRowPlugin','save') called at /twiki1/twiki/prod/lib/TWiki/UI/Rest.pm line 68        TWiki::UI::Rest::gateway('TWiki=HASH(0x824bfcc)') called at /twiki1/twiki/prod/lib/TWiki/UI.pm line 109        TWiki::UI::__ANON__() called at /twiki1/twiki/prod/lib/CPAN/lib///Error.pm line 379        eval {...} called at /twiki1/twiki/prod/lib/CPAN/lib///Error.pm line 371        Error::subs::try('CODE(0x9291de0)','HASH(0x9290358)') called at /twiki1/twiki/prod/lib/TWiki/UI.pm line 158        TWiki::UI::run('CODE(0x82c9cfc)') called at /twiki1/twiki/prod/bin/rest line 31        ModPerl::ROOT::ModPerl::Registry::twiki1_twiki_prod_bin_rest::handler('Apache2::RequestRec=SCALAR(0x824bf78)') called at /usr/lib/perl5/site_perl/5.8.0/i386-linux-thread-multi/ModPerl/RegistryCooker.pm line 203        eval {...} called at /usr/lib/perl5/site_perl/5.8.0/i386-linux-thread-multi/ModPerl/RegistryCooker.pm line 203        ModPerl::RegistryCooker::run('ModPerl::Registry=HASH(0x824c02c)') called at /usr/lib/perl5/site_perl/5.8.0/i386-linux-thread-multi/ModPerl/RegistryCooker.pm line 169        ModPerl::RegistryCooker::default_handler('ModPerl::Registry=HASH(0x824c02c)') called at /usr/lib/perl5/site_perl/5.8.0/i386-linux-thread-multi/ModPerl/Registry.pm line 30        ModPerl::Registry::handler('ModPerl::Registry','Apache2::RequestRec=SCALAR(0x824bf78)') called at /twiki1/twiki/prod/lib/TWiki/Plugins/EditRowPlugin/Table.pm line 0        eval {...} called   

I can't consistantly get the errors to reproduce itself. 25% of the time when I save, I would get an error. The Second error, the move row, I can't seem to reproduce, I keep getting the behavior I reported in Item5594.

To reproduce:

• Create topic Foo with an EditRowPlugin Table
• Create Topic Boo with an EditRowPlugin Table and Include topic Foo in Topic Boo.

-- TWiki:Main/PaulineCheung - 30 Apr 2008

I don't know what's causing that, but I can't reproduce it. I wonder if it might be due to the same problem I fixed for Item5594. Can you try it again?

-- TWiki:Main.CrawfordCurrie - 07 May 2008

From the error messages it looks like it's the same problem, but I need a detailed description of how to reproduce it (with examples) to debug.

-- TWiki:Main.CrawfordCurrie - 08 May 2008

I installed the new EditRowPlugin updates you made, I still get the same errors. I also noticed that the error also manifiests in my production environment, not just my test environment. I also added the add row error above. Also, its no longer an elusive error. It happens all the time.

-- TWiki:Main/PaulineCheung - 09 May 2008

Finally tracked this down to some code that works fine in 4.2.0 but fails in 4.1.2 (my fault, I made an incorrect assumption). It was a fairly special case (a topic with an included topic that contained more than one table, and you edited one of the last two tables in the topic) so I'm not suprised no-one else spotted it.

-- CrawfordCurrie - 10 May 2008