• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5607: double http entries on links in "actionnotify" emails

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension ActionTrackerPlugin Urgent Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Symptom: emails from actionnotify have a double "http://..." in them (globally).

Reason: ActionTrackerPlugin is using the deprecated "getScriptUrlPath" on line 381 of "ActionNotify.pm"

Before we knew this was deprecated, we fixed it by...

[root@kopc1946 ActionTrackerPlugin]# diff ActionNotify.pm ../../../../installed_plugins/tmp/lib/TWiki/Plugins/ActionTrackerPlugin/ActionNotify.pm
382d381
<    my $sun = TWiki::Func::getUrlHost();
384,385c383
<    $sup =~ s/$sun//ogi;
<    $sun .= $sup;
---
>    my $sun = TWiki::Func::getUrlHost() . $sup;

I am not sure, but I think the proper function to use (now) is getScriptUrl()

-- TWiki:Main/PeterStephens 06 May 2008

This idea was to detect urls that have been made using the old function, which is why it was used. I need to take a closer look at this.

The problem is that getScriptUrlPath is not performing to spec - it is returning an absolute URL, rather than the relative URL promised in the doc.

Fixed by sidestepping TWiki::Func and going direct to the config.

-- CrawfordCurrie - 07 May 2008

ItemTemplate
Summary double http entries on links in "actionnotify" emails
ReportedBy TWiki:Main.PeterStephens
Codebase ~twiki4
SVN Range TWiki-5.0.0, Sun, 04 May 2008, build 16770
AppliesTo Extension
Component ActionTrackerPlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:16778
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2008-05-07 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback