• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5703: Putting setting with empty value in 'Topic Preference' interface does not work.

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   patch 4.2.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Use case that demonstrates problem:
  1. Open a topic's "Topic Preference" interface and define two settings with no value such as following:
   * Set DENYTOPICVIEW = 
   * Set DENYTOPICCHANGE = 
  1. Save the change
  2. Reopen Topic Preferences. The two value settings will be run together.

I don't know how to further describe the problem.... deleted line returns maybe?

-- TWiki:Main/LynnwoodBrown - 13 Jun 2008

Easy to reproduce.Confirmed and raising to urgent.

-- KJL

I think I can fix this one

-- KJL

I have a fix. Just testing it and trying to understand a small Perl oddity before I check in the fix.

-- TWiki:Main.KennethLavrsen - 16 Jun 2008

The problem was that a regex made for parsing line by line was too greedy and "ate" the setting line below the one with no value making a goofed result of both.

Fixing the regex in TWiki.pm was no good because that broke the multiline parsing. Instead I made a modified regex but still using the standard regexes for the part that is important for i18n.

Unit tests pass. Waiting for release

-- KJL 16 Jun 2008

ItemTemplate
Summary Putting setting with empty value in 'Topic Preference' interface does not work.
ReportedBy TWiki:Main.LynnwoodBrown
Codebase 4.2.0
SVN Range TWiki-5.0.0, Sun, 01 Jun 2008, build 16865
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:16896 TWikirev:16897
TargetRelease patch
ReleasedIn 4.2.1
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2008-08-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback