• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5772: base and current revisions reversed in diff URL of MailerContrib notify message

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension MailerContrib Normal Closed TWiki:Main.KennethLavrsen patch 4.2.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Diff URL in notification message is backwards (!)

I'm surprised to be the first person to notice this(?).

MailerContrib includes a URL to the differences between the current and the previous revision or changed topics. If you follow that link, you see that the diff is doen backwards; that is, additions are deletions and vice-versa. The diff tells you how to go from the current version to the previous version. Not what I expect!

The problem is easily solved in the mailnotify template as follows: ../templates/mailnotify.tmpl.distributed    2007-12-21 04:37:00.000000000 -0500

+++ ../templates/mailnotify.tmpl        2008-07-11 11:51:32.000000000 -0400

@@ -24,7 +24,7 @@

   <td width="50%">

     <a href="https://develop.twiki.org/do/"view"/Bugs/Item5772"><b>Item5772</b></a>

   </td><td width="30%">

-    <a href="https://develop.twiki.org/do/"rdiff"/Bugs/Item5772?rev1=%BASE_REV%&rev2=%CUR_REV%" rel='nofollow'>%TIME%</a> - %REVISION%

+    <a href="https://develop.twiki.org/do/"rdiff"/Bugs/Item5772?rev2=%BASE_REV%&rev1=%CUR_REV%" rel='nofollow'>%TIME%</a> - %REVISION%

   </td><td width="20%">

     %AUTHOR%

   </td>

-- TWiki:Main/TimotheLitt - 11 Jul 2008

Thanks for the report

I will take care of this.

-- KennethLavrsen - 12 Jul 2008

ItemTemplate
Summary base and current revisions reversed in diff URL of MailerContrib notify message
ReportedBy TWiki:Main.TimotheLitt
Codebase 4.1.2
SVN Range

AppliesTo Extension
Component MailerContrib
Priority Normal
CurrentState Closed
WaitingFor TWiki:Main.KennethLavrsen
Checkins TWikirev:17011 TWikirev:17012
TargetRelease patch
ReleasedIn 4.2.1
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2008-08-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback