• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5857: WysiwigPlugin needs to be more careful about what it changes

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension WysiwigPlugin Urgent No Action Required   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

A recent bug Item5828 reported a situation where the WysiwigPlugin destroys topics irrecoverably. There is discussion in that topic on whether this problem could be avoided by another plugin being written differently. While that probably is correct, that bug revealed some fundamental issues with WysiwygPlugin that could lead to other problems:
  1. The WysiwygPlugin indiscriminantly changes text from HTML to TML in the afterEditHandler, whether that text has been produced by it earlier or not. I believe that the plugin should mark (e.g., by begin/end symbols) the text it converts into HTML and only convert back to TML that portion of the text. Other text could have been added to the topic by other plugins and must not be converted.
  2. The WysiwygPlugin cannot be applied in the normal Plugin ordering. It must be the last plugin that runs before a textarea is edited, and the first plugin that cleans up after editing the text area. Using plugin order to resolve interactions between plugins involving the WysiwygPlugin may not work as it might leave the before or after edit in the wrong order.

I believe resolving (1) is critical. WysiwygPlugin must be more defensive (careful) on where it applies.

-- ThomasWeigert - 31 Jul 2008

-- TWiki:Main/ThomasWeigert - 31 Jul 2008

Seeems a duplicate of 5858

No action

-- TWiki:Main.KennethLavrsen - 31 Jul 2008

ItemTemplate
Summary WysiwigPlugin needs to be more careful about what it changes
ReportedBy TWiki:Main.ThomasWeigert
Codebase 4.2.0
SVN Range TWiki-5.0.0, Sun, 27 Jul 2008, build 17148
AppliesTo Extension
Component WysiwigPlugin
Priority Urgent
CurrentState No Action Required
TargetRelease n/a
Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2008-07-31 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback