• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Topic specific navigation at the bottom is inconsistent.

View has this:

  • r3 < r2 < r1
Rdiff has this:
  • 3 | > | 2 | > | 1

The navigation of rdiff should be the same as view. Rdiff is missing also the links to the diffs (angle brackets should be linked)

I believe, a logical display is this:

  • r3 > r2 > r1

meaning, r3 is bigger (more important/recent) than r2.

But one can also argue the other way around:

  • r3 < r2 < r1

meaning, r1 turns into r2 etc.

PTh


mmm, i think the fact that you were able to list the 2 opposing choices as valid choices, suggests to me we should be useing something totally different (ie, not directional at all). how about consistently using?
  • r1 - r2 - r3
SD
I would put the latest revision first, so start with r3.

This looks like they belong together: r3 - r2 - r1

This is also possible, but also looks like a set: r3, r2, r1

This is simply to much clutter: 3 | > | 2 | > | 1 or 3 | < | 2 | < | 1

I've used the pipe symbol to separate menu items in the bottom bar, so using them here is anyway confusing.

The arrows indicate time flowing, for me this is clear: r3 < r2 < r1 or r3 ← r2 ← r1

-- AC

I am fine with left or right angle brackets (with linked angle brackets) as long as it is consistent in view and rdiff.

-- PTh


added smell - view and rdiff should really get the value from a config, so they are never different -svn:6913 -- SD

I am opening this again since there is still a difference:

  • view: ... | Version: r6 < r5 < r4 < r3 < r2 | History | More topic actions
  • rdiff: ... | Diffs 6< 5 < 4 < 3 | More topic actions

Notice the text "Diffs", the missing "r"s, missing space after "6", and different number of version links shown (4 vs 5)

I think it would be better to consolidate "Version" and "History" in view and rdiff:

  • ... | History: r6 < r5 < r4 < r3 < r2 | More topic actions

with History pointing to the all revisions link.

-- PTh


I have moved the template definitions for the revision info into twiki.tmpl and twiki.pattern.tmpl

I have NOT done the locales changes needed - the labels 'Revision' & 'Diffs' will need replacing with the label 'History'

the question is - in light of the flow on effect of changing text at this late stage, should we really commit this change (dif attached) -- SD

CCRB

  • CC given the knock-on effect of having to source translations of the text in other languages, unless the diffs include the translations my vote is NO. The difference is cosmetic and not worth the risk. If the translations are available and tested, and it's just a case of a checkin, then YES.
  • LB Ditto. If the complete package is provided with translations, then yes. Otherwise, no. It's not that critical.

commited svn:7114 due to delay of release-- SD

ItemTemplate
Summary Inconsistent revision array in view and rdiff
ReportedBy PeterThoeny
AppliesTo Engine
Priority Normal
CurrentState Closed
WaitingFor

Checkins 6913
Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatdiff history.diff r0 manage 8.5 K 2005-10-12 - 08:36 SvenDowideit  
Edit | Attach | Watch | Print version | History: r13 < r12 < r11 < r10 < r9 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r13 - 2005-10-22 - SvenDowideit
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback