• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5971: BuildContrib broken upload on 4.2.2 with template login

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension BuildContrib Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Following twiki.org upgrade to 4.2.2 and move to template login BuildContrib upload failed to work without reporting any error. The upload target runs as normal but topic and attachments do not get updated on twiki.org.

It appears BuildContrib failed to detect the login error and thus did not attempt template login. Look at sub _postForm in Build.pm. Testing :

$response->headers->header('Location') =~ /oopsaccessdenied/
is not sufficient anymore.

Beyond the login error I also get an issue with attachment upload. So the following code causes BuildContrib to die whereas the upload was actually successful:

    die 'Upload failed ', $response->request->uri,
      ' -- ', $response->status_line, "\n", 'Aborting', "\n",
      $response->as_string
      unless $response->is_redirect && $response->headers->header('Location') !~ /oops/;

I'm guessing that might be a problem with twiki.org rather than BuildContrib.

-- TWiki:Main/StephaneLenclud - 31 Aug 2008

Can't reproduce the second issue described above anymore.

-- TWiki:Main.StephaneLenclud - 31 Aug 2008

As Crawford suggested we just replaced:

$response->headers->header('Location') =~ /oopsaccessdenied/

by:

$response->headers->header('Location') =~ /oopsaccessdenied|login/

Bug fixed.

-- TWiki:Main.StephaneLenclud - 31 Aug 2008

ItemTemplate
Summary BuildContrib broken upload on 4.2.2 with template login
ReportedBy TWiki:Main.StephaneLenclud
Codebase 4.2.2
SVN Range TWiki-5.0.0, Mon, 18 Aug 2008, build 17431
AppliesTo Extension
Component BuildContrib
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:17466
TargetRelease n/a
ReleasedIn

Topic revision: r1 - 2008-08-31 - StephaneLenclud
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback