There is quite a bit of duplication between
TWikiDocGraphics and
TWikiDocGraphicsPattern and yet some icons are unique to each set. The docs seem to suggest that TWikiDocGraphics is the "official" icon topic but TWikiDocGraphicsPattern is specified as the
ICONTOPIC
in TWikiPreferences. This is confusing. Let's re-consolidate all the icon files into one topic before Dakar is released.
Therefore, I'm proposing to:
- Consolidate all icon files into TWikiDocGraphics and eliminate TWikiDocGraphicsPattern.
- In cases of conflict between the two sets (for a particular name/use) use the much nicer icons created by AC in TWikiDocGraphicPattern.
- Reorganize them while I'm at it.
- Reset
ICONTOPIC
in TWikiPreferences to TWikiDocGraphics.
LB
I am all for it. Back to KISS, which is an item sometimes overlooked in the
TWiki:Codev.TWikiMission.
PTh
Well, the whole intention of ICONTOPIC (
IconSets) is to be able to use different sets of icons. Classic skin and Cairo pattern use the icons from TWikiDocGraphics, and Dakar uses the ones from TWikiDocGraphicsPattern.
Other skin authors may choose to create a set of their own.
If documentation is not clear or lacking this needs to be addressed.
I've been trying to match the old set in TWikiDocGraphics as much as possible. So duplication is the intent. If there are icons unique to TWikiDocGraphics, this means there are icons that I've missed (or have been added quietly on twiki.org) - but then these have probably not been used in private installations.
AC
The current naming is overcomplex. Skins should attach their icon sets to the skin topic; so the
pattern
skin icons should be drawn from the
PatternSkin topic.
TWikiDocGraphics should probably be renamed
ClassicSkin for consistency, but this is a lot less important. Collapsing the icons into one topic is, IMHO, a retrograde step; much better to establish a standard way for icon sets to naturally extend.
- The TWikiDocGraphics topic must not be renamed, or we'd break many TWiki applications out there. -- PTh
CC
This does not solve the problem if a skin does not have its own icons. Or a skin should always need to attach a whole bunch of icons (easier now with automatic attachments, but still).
Icons are now not only the fancy graphics but also filetype icons in the attachment table.
--
AC
A skin without it's own icons falls back on another skin (has a dependency) or to the default icons, surely?
CC
If I recall, this came about because some
PatterSkin icons were not clear in other skins.
I think that is the important point to remember.
--
TWiki:Main.AntonAylward
Arthur, what is the argument against moving all pattern icons over to
TWikiDocGraphics? All skins would use your icons. (I could have a reason against because I lose "my" icons, but I am all for simplicity and folding the icon topics into one)
In regards to file icons, I noticed that the pub/icn directory is still there. That should be retired in favor of the icon files attached to TWikiDocGraphics.
To have a minimal impact, here is what I suggest:
- Move all icons from TWikiDocGraphicsPattern to TWikiDocGraphics
- Retire TWikiDocGraphicsPattern
- Get the table format with clickable icons from TWiki:TWiki.TWikiDocGraphics (gosh, Dakar docs need a lot more work)
- I think this is no longer necessary, because it is now as simpel as writing
%ICON{bubble}%
to get -- AC
- I think it is because it informs of shortcuts (
%X%
etc) and gives the img tag (for further customization such as title, border, links etc) -- PTh
- The shortcuts in the topic are hardcoded. If they are changed in TWikiPreferences the table gives outdated information. -- AC
- Shortcuts should not change, if they did they need to be reverted or we introduce incompatibilities -- PTh
- No, but site owners might change them theirselves, or introduce new shortcut variables. -- AC
- Configure Pattern skin to use icons (file icons & doc graphics) on TWikiDocGraphics
- I suggest to keep
ICONTOPIC
, only to set its value to TWikiDocGraphics. -- AC
- No code change, e.g. defer retiring of pub/icn to Edinburgh
- These icons are already no longer called, the code has been in place since July. -- AC
PTh
SVN 6831.
AC
I still have 5 icons to go.
AC
Done. 160 icons in all. SVN 6967.
AC