• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

There is quite a bit of duplication between TWikiDocGraphics and TWikiDocGraphicsPattern and yet some icons are unique to each set. The docs seem to suggest that TWikiDocGraphics is the "official" icon topic but TWikiDocGraphicsPattern is specified as the ICONTOPIC in TWikiPreferences. This is confusing. Let's re-consolidate all the icon files into one topic before Dakar is released.

Therefore, I'm proposing to:

  1. Consolidate all icon files into TWikiDocGraphics and eliminate TWikiDocGraphicsPattern.
  2. In cases of conflict between the two sets (for a particular name/use) use the much nicer icons created by AC in TWikiDocGraphicPattern.
  3. Reorganize them while I'm at it.
  4. Reset ICONTOPIC in TWikiPreferences to TWikiDocGraphics.

LB

I am all for it. Back to KISS, which is an item sometimes overlooked in the TWiki:Codev.TWikiMission.

PTh


Well, the whole intention of ICONTOPIC (IconSets) is to be able to use different sets of icons. Classic skin and Cairo pattern use the icons from TWikiDocGraphics, and Dakar uses the ones from TWikiDocGraphicsPattern.

Other skin authors may choose to create a set of their own.

If documentation is not clear or lacking this needs to be addressed.

I've been trying to match the old set in TWikiDocGraphics as much as possible. So duplication is the intent. If there are icons unique to TWikiDocGraphics, this means there are icons that I've missed (or have been added quietly on twiki.org) - but then these have probably not been used in private installations.

AC


The current naming is overcomplex. Skins should attach their icon sets to the skin topic; so the pattern skin icons should be drawn from the PatternSkin topic. TWikiDocGraphics should probably be renamed ClassicSkin for consistency, but this is a lot less important. Collapsing the icons into one topic is, IMHO, a retrograde step; much better to establish a standard way for icon sets to naturally extend.

  • The TWikiDocGraphics topic must not be renamed, or we'd break many TWiki applications out there. -- PTh

CC


This does not solve the problem if a skin does not have its own icons. Or a skin should always need to attach a whole bunch of icons (easier now with automatic attachments, but still).

Icons are now not only the fancy graphics but also filetype icons in the attachment table.

-- AC


A skin without it's own icons falls back on another skin (has a dependency) or to the default icons, surely? CC
If I recall, this came about because some PatterSkin icons were not clear in other skins.
I think that is the important point to remember. -- TWiki:Main.AntonAylward

Arthur, what is the argument against moving all pattern icons over to TWikiDocGraphics? All skins would use your icons. (I could have a reason against because I lose "my" icons, but I am all for simplicity and folding the icon topics into one)

In regards to file icons, I noticed that the pub/icn directory is still there. That should be retired in favor of the icon files attached to TWikiDocGraphics.

To have a minimal impact, here is what I suggest:

  • Move all icons from TWikiDocGraphicsPattern to TWikiDocGraphics
  • Retire TWikiDocGraphicsPattern
  • Get the table format with clickable icons from TWiki:TWiki.TWikiDocGraphics (gosh, Dakar docs need a lot more work)
    • I think this is no longer necessary, because it is now as simpel as writing %ICON{bubble}% to get Speech bubble -- AC
    • I think it is because it informs of shortcuts (%X% etc) and gives the img tag (for further customization such as title, border, links etc) -- PTh
      • The shortcuts in the topic are hardcoded. If they are changed in TWikiPreferences the table gives outdated information. -- AC
        • Shortcuts should not change, if they did they need to be reverted or we introduce incompatibilities -- PTh
          • No, but site owners might change them theirselves, or introduce new shortcut variables. -- AC
  • Configure Pattern skin to use icons (file icons & doc graphics) on TWikiDocGraphics
    • I suggest to keep ICONTOPIC, only to set its value to TWikiDocGraphics. -- AC
  • No code change, e.g. defer retiring of pub/icn to Edinburgh
    • These icons are already no longer called, the code has been in place since July. -- AC

PTh


SVN 6831. AC


I still have 5 icons to go. AC
Done. 160 icons in all. SVN 6967. AC

ItemTemplate
Summary Consolidate all Icons into TWikiDocGraphics
ReportedBy TWiki:Main.LynnwoodBrown
AppliesTo Documentation
Priority Urgent
CurrentState Closed
WaitingFor

Checkins 6798 6799 6831 6832 6833 6835 6845 6867 6907 6948 6967 6968 7019 7027 7312 7313 7314
Edit | Attach | Watch | Print version | History: r19 < r18 < r17 < r16 < r15 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r19 - 2005-10-11 - ArthurClemens
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback