Item6220 < Bugs

AppliesTo:	Component:	Priority:	CurrentState:	WaitingFor:	TargetRelease	ReleasedIn
Extension	TwistyPlugin	Normal	Closed		patch	4.3.0

A twisty in a TWiki table cell destroys the table because the plugin introduces newlines.

Test case:

|*Heading 1*|*Heading 2*|*Heading 3*|
| Text | Text |%TWISTY{}%my twisty content%ENDTWISTY%|

renders as:

Heading 1	Heading 2	Heading 3
Text	Text	More... Close my twisty content

As of today there is a newline between two spans if you look at the raw HTML of this page:

<span class="twistyPlugin twikiMakeVisibleInline">
 <span id="twistyIdItem62201show" ...

-- TWiki:Main/PeterThoeny - 24 Mar 2009

Fix:

Index: lib/TWiki/Plugins/TwistyPlugin.pm
===================================================================
--- lib/TWiki/Plugins/TwistyPlugin.pm   (revision 17851)
+++ lib/TWiki/Plugins/TwistyPlugin.pm   (working copy)
@@ -410,7 +410,7 @@
 
 sub _wrapInButtonHtml {
     my ( $text, $mode ) = @_;
-    return _wrapInContainerHideIfNoJavascripOpen($mode) . "\n" . $text
+    return _wrapInContainerHideIfNoJavascripOpen($mode) . " " . $text
       . _wrapInContainerDivIfNoJavascripClose($mode);
 }
 
@@ -421,7 +421,7 @@
 
 sub _wrapInContentHtmlClose {
     my ($mode) = shift;
-    return "</$mode>\n<!--/twistyPlugin-->";
+    return "</$mode> <!--/twistyPlugin-->";
 }
 
 sub _wrapInContainerHideIfNoJavascripOpen {

-- TWiki:Main/PeterThoeny - 24 Mar 2009

Strangely no checkin info in table. r17892 was for trunk, r17893 for 4.3 branch.

-- TWiki:Main.PeterThoeny - 24 Mar 2009

Ah, it got added while I edited the page. Restored checkin info form field from history.

-- TWiki:Main.PeterThoeny - 24 Mar 2009

ItemTemplate
Summary	TwistyPlugin: Twisty can't be placed in TWiki table cells
ReportedBy	TWiki:Main.PeterThoeny
Codebase
SVN Range	TWiki-5.0.0, Mon, 23 Feb 2009, build 17838
AppliesTo	Extension
Component	TwistyPlugin
Priority	Normal
CurrentState	Closed
WaitingFor
Checkins	TWikirev:17892 TWikirev:17893
TargetRelease	patch
ReleasedIn	4.3.0

Item6220: TwistyPlugin: Twisty can't be placed in TWiki table cells

Item Form Data

Edit Form Data

Detail