• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6379: Correct a configure bug where a defined empty string '' is converted into 'NOT SET'

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine Configure Normal Closed TWiki:Main.VernonLyon patch 5.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

In configure all defined empty strings '' are converted into 'NOT SET'

This is done here in: lib/TWiki/Configure/Checkers/BasicSanity.pm

    # If we got this far without definitions for key variables, then
    # we need to default them. otherwise we get peppered with
    # 'uninitialised variable' alerts later.
    foreach my $var qw( DataDir DefaultUrlHost PubUrlPath
                        PubDir TemplateDir ScriptUrlPath LocalesDir ) {
        # NOT SET tells the checker to try and guess the value later on
        $TWiki::cfg{$var} ||= 'NOT SET';
    }

To fix we should change the line to:

        $TWiki::cfg{$var} = 'NOT SET' unless defined $TWiki::cfg{$var};

This is a small change that will only affect those who use empty strings as part of their configuration.

My ScriptUrlPath is set to an empty string.

-- TWiki:Main/VernonLyon - 30 Dec 2009

Thank you Vernon! Could you also fix the 4.3 branch?

-- TWiki:Main.PeterThoeny - 31 Dec 2009

Setting to "waiting for release" for TWiki-5.0.0.

-- TWiki:Main.PeterThoeny - 29 May 2010

ItemTemplate
Summary Correct a configure bug where a defined empty string '' is converted into 'NOT SET'
ReportedBy TWiki:Main.VernonLyon
Codebase 4.3.2, ~twiki4
SVN Range TWiki-5.0.0, Sun, 27 Sep 2009, build 18153
AppliesTo Engine
Component Configure
Priority Normal
CurrentState Closed
WaitingFor TWiki:Main.VernonLyon
Checkins TWikirev:18258
TargetRelease patch
ReleasedIn 5.0.0
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2010-05-31 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback