Item6438 < Bugs

AppliesTo:	Component:	Priority:	CurrentState:	WaitingFor:	TargetRelease	ReleasedIn
Engine		Urgent	Closed		minor	5.0.0

sub META in TWiki.pm get meta data via: $meta = $this->inContext( 'can_render_meta' ). That contect is set in the view script, e.g. the meta data of the base topic is stored in context. However, sub META uses web and topic of the current topic.

This is a bug, visible in the new TopMenuSkin if you in a web other than TWiki web and you have parents: The parent link will point to the TWiki web instead of the current web.

Test: This topic's parent is set to WebNotify in current Bugs web. See parent "P", it points to TWiki.WebNotify. It should point to Bugs.WebNotify.

Sidenote: Context variables are global variables. Whoever implemented the context variables in TWiki made a bad design decision.

-- TWiki:Main/PeterThoeny - 26 Apr 2010

Not sure what the best fix is:

Use web name, topic name and meta data of current web.topic by default. Add web="" and topic="" parameter to override web.topic.
Use web name, topic name and meta data of base web.topic by default. Add web="" and topic="" parameter to override web.topic.

Number 1 is more logical, and in line with other TWiki variables that take effect on current web.topic. But it is likely to break existing TWiki applications. Number 2 does not change spec for meta data reference, but is not logical.

Opinions?

-- TWiki:Main.PeterThoeny - 26 Apr 2010

Hi Peter.. let us go with option 1 if it fixes the issue.

better solution can be brainstormed/implemented later.. after the release

-- TWiki:Main.SopanShewale - 27 Apr 2010

After re-considering I decided to go for option 2. Better to stay compatible. I added a new topic="" parameter (no web="" parameter). Docs updated at VarMETA.

-- TWiki:Main.PeterThoeny - 28 Apr 2010

This fix also fixed bug Item6386: breadcrumb shows improper topic if used in top bar.

-- TWiki:Main.PeterThoeny - 06 May 2010

ItemTemplate
Summary	%META with new `topic` parameter; fix for %META using current web.topic scope, but base topic's meta data
ReportedBy	TWiki:Main.PeterThoeny
Codebase	~twiki4
SVN Range	TWiki-5.0.0, Wed, 21 Apr 2010, build 18495
AppliesTo	Engine
Component
Priority	Urgent
CurrentState	Closed
WaitingFor
Checkins	TWikirev:18534 TWikirev:18539 TWikirev:18540 TWikirev:18541
TargetRelease	minor
ReleasedIn	5.0.0

Item6438: %META with new `topic` parameter; fix for %META using current web.topic scope, but base topic's meta data

Item Form Data

Edit Form Data

Detail

Item6438: %META with new topic parameter; fix for %META using current web.topic scope, but base topic's meta data

Item Form Data

Edit Form Data

Detail

Item6438: %META with new `topic` parameter; fix for %META using current web.topic scope, but base topic's meta data