• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6491: Missing template change in TWiki-5.0.0 for EDITMETHOD setting

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   patch 5.0.2

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Bug reported by TWiki:Main/JohnGage in TWiki:Codev/PreferencesForRawEditOrWysiwygEdit on 2010-06-14:

"It looks like one of the requred changes did not make it into the 5.0.0 package. I had to change the following file to get the twiki to use the EDITMETHOD setting:"

diff templates/viewtopicactionbuttons.tmpl*
7c7
< %TMPL:DEF{"edit_topic_link"}%<span><a href='%SCRIPTURL{"edit"}%/%BASEWEB%/%BASETOPIC%?t=%GMTIME{"$epoch"}%%TMPL:P{"url_param_editaction"}%;nowysiwyg=%IF{ "$ EDITMETHOD='wysiwyg'" then="0" else="1"  }%' rel='nofollow' %MAKETEXT{"title='Edit this topic text' accesskey='e'>[_1] &Edit" args="<img src='%ICONURLPATH{uweb-o}%' width='16' height='16' border='0' alt='' />"}%</a></span>%TMPL:END%
---
> %TMPL:DEF{"edit_topic_link"}%<span><a href='%SCRIPTURL{"edit"}%/%BASEWEB%/%BASETOPIC%?t=%GMTIME{"$epoch"}%%TMPL:P{"url_param_editaction"}%%IF{"context TinyMCEPluginEnabled" then="" else=";nowysiwyg=1"}%' rel='nofollow' %MAKETEXT{"title='Edit this topic text' accesskey='e'>[_1] &Edit" args="<img src='%ICONURLPATH{uweb-o}%' width='16' height='16' border='0' alt='' />"}%</a></span>%TMPL:END%

-- TWiki:Main/PeterThoeny - 14 Jun 2010

This is now in SVN trunk and 5.0 branch. Thanks John!

Initial proposal at TWiki:Codev.PreferencesForRawEditOrWysiwygEdit with Item6295.

Followup: This feature is not documented properly - tracked in Item6604.

-- TWiki:Main.PeterThoeny - 2010-11-05

diff -c TWikiPreferences.txt =1/TWikiPreferences.txt
*** unzipped/TWikiPreferences.txt	Wed Aug  5 01:40:43 2009
--- TWikiPreferences.txt	Fri Apr 29 12:22:22 2011
***************
*** 313,319 ****
           * #Set NEWLINKFORMAT = <a href="%SCRIPTURLPATH{"edit"}%/$web/$topic?topicparent=%WEB%.%TOPIC%" rel="nofollow" title="%MAKETEXT{"$text (this topic does not yet exist; you can create it)"}%">$text</a>
        * alternative setting: 
           * #Set NEWLINKFORMAT = <a class="twikiNewLink" href="%SCRIPTURLPATH{"edit"}%/$web/$topic?topicparent=%WEB%.%TOPIC%" rel="nofollow" title="%MAKETEXT{"Create this topic"}%">$text</a>
!          * Set NEWLINKFORMAT = <a class="twikiNewLink" href="%SCRIPTURLPATH{"edit"}%/$web/$topic?topicparent=%WEB%.%TOPIC%;nowysiwyg=%IF{  "$ EDITMETHOD='wysiwyg'" then="0" else="1"  }%"    rel="nofollow" title="%MAKETEXT{"this topic does not yet exist; you can create tit"}%">$text</a>
  
     * %SYSTEMWEB%.PreviewBackground image: 
        * Set PREVIEWBGIMAGE = %PUBURLPATH%/%SYSTEMWEB%/PreviewBackground/preview2bg.gif
--- 325,331 ----
           * #Set NEWLINKFORMAT = <a href="%SCRIPTURLPATH{"edit"}%/$web/$topic?topicparent=%WEB%.%TOPIC%" rel="nofollow" title="%MAKETEXT{"$text (this topic does not yet exist; you can create it)"}%">$text</a>
        * alternative setting: 
           * #Set NEWLINKFORMAT = <a class="twikiNewLink" href="%SCRIPTURLPATH{"edit"}%/$web/$topic?topicparent=%WEB%.%TOPIC%" rel="nofollow" title="%MAKETEXT{"Create this topic"}%">$text</a>
!          * Set NEWLINKFORMAT = <a class="twikiNewLink" href="%SCRIPTURLPATH{"edit"}%/$web/$topic?topicparent=%WEB%.%TOPIC%;nowysiwyg=%IF{  "$ EDITMETHOD='wysiwyg'" then="0" else="1"  }%"    rel="nofollow" title="%MAKETEXT{"this topic does not yet exist; you can create it"}%">$text</a>
  
     * %SYSTEMWEB%.PreviewBackground image: 
        * Set PREVIEWBGIMAGE = %PUBURLPATH%/%SYSTEMWEB%/PreviewBackground/preview2bg.gif

-- TWiki:Main.SteveKelem - 2011-05-02

"you can create tit" - thank you Steve for the typo alert. This item is set to "waiting for release", I'll use Item6593 to check in the fix.

-- TWiki:Main.PeterThoeny - 2011-05-02

Actually, I see that SVN trunk and 5,0 branch have already "you can create it", so no action required.

-- TWiki:Main.PeterThoeny - 2011-05-02

ItemTemplate
Summary Missing template change in TWiki-5.0.0 for EDITMETHOD setting
ReportedBy TWiki:Main.PeterThoeny
Codebase 5.0.0, 5.0.1, ~twiki4
SVN Range TWiki-5.0.0, Tue, 08 Jun 2010, build 18947
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:19178 TWikirev:19179 TWikirev:19180 TWikirev:19763 TWikirev:19764
TargetRelease patch
ReleasedIn 5.0.2
Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2011-05-07 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback