• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6753: FindElsewherePlugin fails on Specific Links [ [ WikiWord ][displayed reference] ] when WikiWord doesn't exist.

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension FindElsewherePlugin Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Problem

Links of the form:

[[WikiWord][This is a wiki word]]

gets turned into plain text "This is a wiki word" when displayed if the WikiWord doesn't exist. If the WikiWord

does exist FindElsewherePlugin takes a different code path that doesn't cause the problem.

This should be a problem on every TWiki release.

Cause/Solution

The problem is in FindElsewherePlugin/Core.pm. The last line in the function findTopicElsewhere reads:


return $linkText;

but $linkText is the link description in this case and not the original bracketed expression.

The return statement should read:


return $original;

which is defined as the bracketed expression that was originally passed in.

With this change in place the link is properly rendered as a missing link.

-- TWiki:Main/JohnRouillard - 2011-06-16

Thanks John. This is now in SVN trunk and 5.9 branch. Uploaded to twiki.org repository as well.

-- TWiki:Main.PeterThoeny - 2011-06-17

ItemTemplate
Summary FindElsewherePlugin fails on Specific Links [ [ WikiWord ][displayed reference] ] when WikiWord doesn't exist.
ReportedBy TWiki:Main.JohnRouillard
Codebase ~twiki4
SVN Range TWiki-5.1.0-trunk, Mon, 13 Jun 2011, build 21497
AppliesTo Extension
Component FindElsewherePlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:21520 TWikirev:21521 TWikirev:21522 TWikirev:21523
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2011-06-17 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback