• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6783: Incorrect file test in bin/configure

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine configure Normal Closed   patch 5.1.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Version: TWiki 5.0.2

Description: In the "bin/configure" file, line 149-152:

$foundAt = "was found at $path/$modpath";
if ( !-r $foundAt ) {
$foundAt .= ", but I don't have permission to read it.";
}

'-r' in 'if' statement means "File is readable by effective uid/gid(or not)", while we can see the $foundAt is just a string, not 'File'. I think it maybe wrote as below:

$foundAt = "was found at $path/$modpath";
if ( !-r $path/$modpath ) {
$foundAt .= ", but I don't have permission to read it.";
}

Hope you can verify this issue. Thanks,

Phillip

-- TWiki:Main/PhillipHuang - 2011-08-04

Confirmed. Thanks for reporting and for proposed fix!

-- TWiki:Main.PeterThoeny - 2011-08-04

This is now fixed in trunk and 5.0 branch.

-- TWiki:Main.PeterThoeny - 2011-08-04

ItemTemplate
Summary Incorrect file test in bin/configure
ReportedBy TWiki:Main.PhillipHuang
Codebase ~twiki4, 5.0.2
SVN Range TWiki-5.1.0-rc1, Mon, 18 Jul 2011, build 21779
AppliesTo Engine
Component configure
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:21893 TWikirev:21894
TargetRelease patch
ReleasedIn 5.1.0
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2011-08-22 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback