• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6806: Uninitialized value error in UI/Save.pm

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Low Closed   patch 5.1.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Encountered following error in one of my webserver's log file (wrapped for easier display):

[Sat Sep 10 15:57:28 2011] [error] [client xxx.xxx.xxx.xxx] [Sat Sep 10 15:57:28 2011] save: 

Use of uninitialized value in lc at /var/www/servers/twiki/lib/TWiki/UI/Save.pm line 469.

Bug is improper defaulting:

my $editaction = lc($query->param( 'editaction' )) || '';

Should be:

my $editaction = lc($query->param( 'editaction' ) || '');

TWiki SVN 20850 (trunk) - Visual diff note: the last ')' is moved.

I don't have a reproducer (I think it had something to do with a browser back), but this is an obvious coding bug. I also didn't run down the use to make sure that a null $editaction is sensible...

The same code is in 4.2.3 at line 428, so it's an old bug.

-- TWiki:Main/TimotheLitt - 2011-09-10

Thanks Timothe! This is now fixed in SVN trunk and 5.1 branch.

-- TWiki:Main.PeterThoeny - 2011-09-12

ItemTemplate
Summary Uninitialized value error in UI/Save.pm
ReportedBy TWiki:Main.TimotheLitt
Codebase ~twiki4, 5.1.0, 4.2.3
SVN Range TWiki-5.1.0, Sat, 20 Aug 2011, build 22128
AppliesTo Engine
Component

Priority Low
CurrentState Closed
WaitingFor

Checkins TWikirev:22273 TWikirev:22274
TargetRelease patch
ReleasedIn 5.1.1
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2012-01-16 - GeorgeTrubisky
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback