• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6920: RCS problems under Fedora 17 (+other new rcs) prevent Configure from running

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   patch 5.1.2

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Fedora 17 supplies RCS V 5.8.1. lib/TWiki/Configure/Checker.pm can't parse this format of version string and fails with a numeric comparision to string error. The code treats the version as a floating point number, which can't have more than one decimal point.

You can see this simply by entering Configure - the "Store settings" section will be filled with errors.

Apply this patch to 5.1 to fix by making only the first two fields significant in the comparison:

svn diff /var/www/servers/twiki/lib/TWiki/Configure/Checker.pm
Index: /var/www/servers/twiki/lib/TWiki/Configure/Checker.pm
===============================================================
--- /var/www/servers/twiki/lib/TWiki/Configure/Checker.pm       (revision 22335)
+++ /var/www/servers/twiki/lib/TWiki/Configure/Checker.pm       (working copy)
@@ -299,7 +299,7 @@
         $err .= $key.' is not set';
     } else {
         my $version = `$prog -V` || '';
-        if ( $version =~ /(\d+(\.\d+)+)/ ) {
+        if ( $version =~ /\s(\d+\.\d+)((:?\.\d+)*)/ ) {
             $version = $1;
         } else {
             $err .= $this->ERROR($prog.' did not return a version number (or might not exist..)');

The following patch is against HEAD:

svn diff core
Index: core/lib/TWiki/Configure/Checker.pm
===================================================================
--- core/lib/TWiki/Configure/Checker.pm (revision 23209)
+++ core/lib/TWiki/Configure/Checker.pm (working copy)
@@ -299,7 +299,7 @@
         $err .= $key.' is not set';
     } else {
         my $version = `$prog -V` || '';
-        if ( $version !~ /Can't exec/ && $version =~ /(\d+(\.\d+)+)/ ) {
+        if ( $version !~ /Can't exec/ && $version =~ /\s(\d+\.\d+)((:?\.\d+)*)/ ) {
             $version = $1;
         } else {
             $version = '';
-- TWiki:Main/TimotheLitt - 2012-08-31

Thank you Timothe!

This is now fixed in SVN trunk and TWiki-5.1 branch.

-- TWiki:Main.PeterThoeny - 2012-09-04

Thanks. By the way, no e-mail notification received for your update. Please don't expect me to poll for updates to this (or any) topic....

-- TWiki:Main.TimotheLitt - 2012-09-05

ItemTemplate
Summary RCS problems under Fedora 17 (+other new rcs) prevent Configure from running
ReportedBy TWiki:Main.TimotheLitt
Codebase ~twiki4, 5.1.1, 5.1.0
SVN Range TWiki-5.1.1-trunk, Thu, 23 Aug 2012, build 23194
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:23221 TWikirev:23222
TargetRelease patch
ReleasedIn 5.1.2
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2012-10-07 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback