• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6982: Links in INCLUDE across web have gratuitous trailing parenthesis

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Low Closed   patch 5.1.3

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Obscure bug:

  • TestWikiWordBug in Sandbox web has a section "test" that uses %TESTPARAM%:
    %STARTSECTION{test}%
      * param: %TESTPARAM%
    %ENDSECTION{test}%
  • TestWikiWordBug in Main web has this:
    %INCLUDE{ "Sandbox.TestWikiWordBug" section="test" TESTPARAM="Test TWiki.WikiWord bug" }%
  • Defective output:
  • Expected:

Cause: Gratuitous ) in regex of TWiki::_fixupIncludedTopic, introduced by Item6840 fix.

--- TWiki.pm   (revision 23580)
+++ TWiki.pm   (working copy)
@@ -2194,7 +2194,7 @@
         # Prefix web name to WikiWord to make links work, such as:
         # 'TopicName' to 'Web.TopicName'
         # TWikibug:Item6840: Exclude 'WikiWordWeb.TopicName' using translation token
-        $text =~ s/(?:^|(?<=[\s(]))($regex{webNameRegex}\.($regex{wikiWordRegex}|$regex{abbrevRegex}))/-$TranslationToken$1)/go;
+        $text =~ s/(?:^|(?<=[\s(]))($regex{webNameRegex}\.($regex{wikiWordRegex}|$regex{abbrevRegex}))/-$TranslationToken$1/go;
         $text =~ s#(?:^|(?<=[\s(]))($regex{wikiWordRegex})#$fromWeb.$1#go;
         $text =~ s/-$TranslationToken//go;
     }

-- TWiki:Main/PeterThoeny - 2012-10-13

ItemTemplate
Summary Links in INCLUDE across web have gratuitous trailing parenthesis
ReportedBy TWiki:Main.PeterThoeny
Codebase ~twiki4, 5.1.2
SVN Range TWiki-5.1.1-trunk, Wed, 10 Oct 2012, build 23593
AppliesTo Engine
Component

Priority Low
CurrentState Closed
WaitingFor

Checkins TWikirev:23623 TWikirev:23624
TargetRelease patch
ReleasedIn 5.1.3
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2012-12-16 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback