• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
• Does this site look broken?. Use the LitterTray web for test cases.

Item7117: expandVariablesOnTopicCreation may fail if web & topic parameters are missing

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   patch 5.1.4

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The develop.twiki.org TWiki failed when adding a comment with default comment box.

Chain:

  • TWiki.Commentplugin calls TWiki::Func::expandVariablesOnTopicCreation() just with text, without web and topic parameter (as documented)
  • TWiki::expandVariablesOnTopicCreation calls expandAllTags( $this, \$etext, $theTopic, $theWeb ) with undefined web and tropic parameters

Fix:

  • In TWiki::expandVariablesOnTopicCreation, define web and topic if missing.
  • Add optional web and topic parameters to TWiki::Func::expandVariablesOnTopicCreation()

-- TWiki:Main/PeterThoeny - 2013-01-05

This is now fixed in SVN trunk and 5.1 branch.

-- TWiki:Main.PeterThoeny - 2013-01-05

ItemTemplate
Summary expandVariablesOnTopicCreation may fail if web & topic parameters are missing
ReportedBy TWiki:Main.PeterThoeny
Codebase ~twiki4, 5.1.3
SVN Range TWiki-5.1.3-trunk, Tue, 01 Jan 2013, build 24634
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:24712 TWikirev:24713 TWikirev:24714 TWikirev:24715
TargetRelease patch
ReleasedIn 5.1.4
Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r7 - 2013-02-18 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2023 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback