• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7136: TINYMCEPLUGIN_DISABLE not working well

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   patch 5.1.4

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

When TINYMCEPLUGIN_DISALBE is on
  • The WYSIWYG button is displayed on a view page though it's not supposed to be displayed
  • If the WYSIWYG button is clicked, a raw edit page shows up. But the buttons below the lower right corner of the text area (textarea buttons) are not displayed
The cause of these problems are
  • The WYSIWYG button is displayed as long as TinyMCEPlugin is enabled. TINYMCEPLUGIN_DISABLE does not count
  • The textarea buttons are displayed if TinyMCEPlugin is not enabled or nowysiwyg=1 URL paramater is provided. When the WYSIWYG button is clicked while TINYMCEPLUGIN_DISABLED is on, that condition is not met
The following changes are made to fix the problems
  • TinyMCEPlugin's initPlugin() enters the TinyMCEPluginAvailable context if TINYMCEPLUGIN_DISALBE is false
  • core's templates/viewtopicactionbuttons.tmpl is modified to see the TinyMCEPluginAvailable context instead of TinyMCEPluginEnabled context, which is in effect as long as the plug-in is installed
  • PatternSkin's templates/edit.pattern.tmpl checks the textareas_hijacked context instead of the TinyMCEPluginEnabled to determine whether or not to display the textarea buttons
What would happen if the latest TinyMCEPlugin and/or PatternSkin are used without the core change?
  • TinyMCEPlugin has no problem because it just puts an additional context, which is referred to by nobody
  • PatternSkin has no problem because the textareas_hijacked context has been set when WYSIWYG editing is done by TinyMCEPlugin
The latest version of TWiki core is supposed to be used together with the latest version of bundled plug-ins. A release branches core is supposed to be used together with the plug-ins in the same branch. As such, this fix won't cause any problems under all possible circumstances.

-- TWiki:Main/HideyoImazu - 2013-02-01

This seems to be fixed, so setting it to "waiting for release" state.

-- TWiki:Main.PeterThoeny - 2013-02-16

ItemTemplate
Summary TINYMCEPLUGIN_DISABLE not working well
ReportedBy TWiki:Main.HideyoImazu
Codebase ~twiki4, 5.1.3
SVN Range TWiki-5.1.3-trunk, Fri, 11 Jan 2013, build 24780
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:24847 TWikirev:24848 TWikirev:24849 TWikirev:24851 TWikirev:24852 TWikirev:24853
TargetRelease patch
ReleasedIn 5.1.4
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2013-02-18 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback