While creating Item721 I noticed that the direct attachment link in the attachment table did not increment, even though I uploaded rev 2 of the attached file.

It looks like the behaviour of the direct link is that it is pointing to revision "head minus one" of the attachment.

-- TWiki:Main.SteffenPoulsen - 19 Oct 2005

from looking at the topic source, develop is setting the initial rev to 0, while cairo set it to 1.1 - so its not the rendering, its the attach itself thats off by one

svn:7095

all META:FILEATTACH lines in svn need to be checked and fixed

-- SD

Urgh, topics are versioned starting from revision 1, but attachments are versioned starting from version 0? That doesn't sound like a spec that has been given enough thought - I know it sounds confusing to me already I can't find the spec though, it is in the source?

-- TWiki:Main.SteffenPoulsen - 20 Oct 2005

aaargh - no, that was the bug. I fixed it so they now start at 1. -- SD

I need new glasses Anyway, there's still a problem - now when there's more than one attachment to a topic, the rev parameter is empty for all attachments in the attachment table.

I didn't get the part about the META:FILEATTACH - the .txt-files that I have in my repository that carry attachments contain either version="1.1" and up or version="1" and up (I believe both are OK?) - there are no files with i.e. version="0" to be seen.

-- TWiki:Main.SteffenPoulsen - 20 Oct 2005

ah, cool found it - the Autoattach code is horrible, and was loosing the data in the META, svn: 7107

-- SD

Thanks for fixing that. I'd be interested if you have a better idea of how to implement autoattach.

-- MC