• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

While creating Item721 I noticed that the direct attachment link in the attachment table did not increment, even though I uploaded rev 2 of the attached file.

It looks like the behaviour of the direct link is that it is pointing to revision "head minus one" of the attachment.

-- TWiki:Main.SteffenPoulsen - 19 Oct 2005

from looking at the topic source, develop is setting the initial rev to 0, while cairo set it to 1.1 - so its not the rendering, its the attach itself thats off by one

svn:7095

all META:FILEATTACH lines in svn need to be checked and fixed frown

-- SD

Urgh, topics are versioned starting from revision 1, but attachments are versioned starting from version 0? That doesn't sound like a spec that has been given enough thought - I know it sounds confusing to me already smile I can't find the spec though, it is in the source?

-- TWiki:Main.SteffenPoulsen - 20 Oct 2005

aaargh - no, that was the bug. I fixed it so they now start at 1. -- SD

I need new glasses smile Anyway, there's still a problem - now when there's more than one attachment to a topic, the rev parameter is empty for all attachments in the attachment table.

I didn't get the part about the META:FILEATTACH - the .txt-files that I have in my repository that carry attachments contain either version="1.1" and up or version="1" and up (I believe both are OK?) - there are no files with i.e. version="0" to be seen.

-- TWiki:Main.SteffenPoulsen - 20 Oct 2005

ah, cool smile found it - the Autoattach code is horrible, and was loosing the data in the META, svn: 7107

-- SD

Thanks for fixing that. I'd be interested if you have a better idea of how to implement autoattach.

-- MC

ItemTemplate
Summary Direct link to attachment in attachment table is one revision behind
ReportedBy SteffenPoulsen
AppliesTo Engine
Priority Normal
CurrentState Closed
WaitingFor

Checkins 7095 7096 7107
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r8 - 2005-10-21 - MartinCleaver
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2021 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback