• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7232: Size attribute of a TWiki Forms field needs to allow space anywhere

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   major 6.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The size attribute of a TWik form field needs to allow space anywhere for compatibility with TWiki 4.X. Specifically for a textarea field, the size attribute is e.g. "100x10" but "100 x 10" was allowed in TWiki 4.X. Those extra spaces need to be torelated in the trunk and 5.X releases for backward compatibility.

In the trunk, TWiki::Form::FieldDefinition::new() has the following lines. These eliminate leading and trailing spaces in the size attribute of a form field.

$attrs{size} =~ s/^\s*//;
$attrs{size} =~ s/\s*$//;

In TWiki release 4.1, the corresponding processing is done in TWiki::Form::_cleanField() at the following line. This eliminates spaces (and other non-word characters excluding dot) anywhere.

$text =~ s/[^A-Za-z0-9_\.]//go;

Simply changing the two lines shown above to the following, the goal is achieved.

$attrs{size} =~ s/\s+//g;

-- TWiki:Main/HideyoImazu - 2013-04-17

ItemTemplate
Summary Size attribute of a TWiki Forms field needs to allow space anywhere
ReportedBy TWiki:Main.HideyoImazu
Codebase ~twiki4
SVN Range TWiki-5.1.3-trunk, Fri, 12 Apr 2013, build 25760
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:25770 TWikirev:25771
TargetRelease major
ReleasedIn 6.0.0
Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2013-10-15 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback