• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7284: TablePlugin taking HTML tags into account in sorting

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension TablePlugin Normal Closed   major 6.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Somewhere between TWiki release 4.2.3 and 4.3.2, TablePlugin changed its behavior with sorting by a text column. Up to 4.2.3, HTML tags were removed before column values are compared. TWiki::Plugins::TablePlugin::Core::emitTable() had the folloing lines.

@curTable = map { $_->[0] }
  sort { $b->[1] cmp $a->[1] }
  map { [ $_, _stripHtml( $_->[$sortCol]->{text} ) ] }
  @curTable;

But from 4.3.2 onward, the corresponding lines has been changed as follows. This means HTML tags are not removed.

@curTable = map { $_->[0] }
  sort { $b->[1] cmp $a->[1] }
  map { [ $_, lc( $_->[$sortCol]->{text} ) ] }
  @curTable;
This is considered to be devolution. Making the sort case insensitive is a good idea but not removing HTML tags is not.

-- TWiki:Main/HideyoImazu - 2013-06-25

Makes sense to fix as proposed.

-- TWiki:Main.PeterThoeny - 2013-06-26

FYI, the removal of stripping HTML was done in Item6031 on 2008-09-30. I think it was unintentional.

-- TWiki:Main.PeterThoeny - 2013-06-26

Make sure the docs are updated before uploading the new package.

-- TWiki:Main.PeterThoeny - 2013-06-26

ItemTemplate
Summary TablePlugin taking HTML tags into account in sorting
ReportedBy TWiki:Main.HideyoImazu
Codebase ~twiki4
SVN Range TWiki-5.1.3-trunk, Tue, 04 Jun 2013, build 25988
AppliesTo Extension
Component TablePlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:26018 TWikirev:26019
TargetRelease major
ReleasedIn 6.0.0
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2013-10-15 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback