• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7350: Add sort="on" parameter to GROUPS variable

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   major 6.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

As of this writing, %GROUPS% puts members sorted in cUID. The member order may look random and test/unit/Fn_GROUPS.pm would become a bit messy to conform that behavior. So stopping member sorting.

-- TWiki:Main/HideyoImazu - 2013-09-19

I might have put in the sorting of groups a few days ago. I think it is better to show the group list sorted. Sorting fails though if a group has no corresponding topic in the Main web. By default here is only one, the TWikiBaseGroup, which is OK/good to have at the top.

I think it is better to fix the unit test to be aware of sorting.

-- TWiki:Main.PeterThoeny - 2013-09-20

This is about the order of members of a group rather the order of groups listed. As I mentioned, if the members of TWikiBaseGroup are sorted in the cUID order, it looks random. With an ordinary group defined by a topic, if the members are sorted in the cUID order, the resulting order is different from the order listed in the topic, which may puzzle some users.

-- TWiki:Main.HideyoImazu - 2013-09-20

As it is coded now, the table is ASCII sorted based on the string of table row, such as "| [[Main.SomeGroup][SomeGroup]] | [[Main.UserA][UserA]], [[Main.UserB][UserB]] |" by default. That is, the sorting looks OK as long as the group topics exist. If not, they will be sorted too, but shown before the groups with topic.

The members are currently not sorted. Let me also ASCII sort them based on the resulting string.

-- TWiki:Main.PeterThoeny - 2013-09-20

I fixed the code so that members are now sorted after formatting to WikiName, not before as it originally was. Could you test if this fixes the issue?

-- TWiki:Main.PeterThoeny - 2013-09-20

How about introducing sort="on" parameter to %GROUPS% and make the sorting off by default? My concern is that the order of members may be intentional and changing the order on TWikiGroups may puzzle users. For example, the first member of a group may be the head of the group, there might be subgroups within a group and members are bundled together based on the subgroups they belong.

-- TWiki:Main.HideyoImazu - 2013-09-27

I don't have a strong opinion on this one. The sort parameter sounds good.

-- TWiki:Main.PeterThoeny - 2013-10-02

I've introduced the sort="on" parameter and made sorting not happen by default.

-- TWiki:Main.HideyoImazu - 2013-10-10

ItemTemplate
Summary Add sort="on" parameter to GROUPS variable
ReportedBy TWiki:Main.HideyoImazu
Codebase ~twiki4
SVN Range TWiki-6.0.0-trunk, Wed, 18 Sep 2013, build 26383
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:26405 TWikirev:26417 TWikirev:26481
TargetRelease major
ReleasedIn 6.0.0
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2013-10-15 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback