• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7477: Add $br to newline and separator parameter of SEARCH

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Enhancement Closed   patch 6.0.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The fix for Item7476 adds the concept of a $br variable to the documentation for the SEARCH newline parameter; this did not work when I tested it on my patched 6.0.0.

I also note that the changed code of TWiki::Render::protectFormFieldValue does not match the claim of its function header:

* newlines are replaced with <br> or the value of $attrs->{newline}

Specifically, the changed code does not replace newlines with <br /> when $attrs->{newline} is not present. It isn't clear to me if the header comment is wrong, or if the implementation needs to be updated to meet requirements.

-- TWiki:Main/DavidDAllen - 2014-03-31

The code comment needs to be updated. The documentation in VarSEARCH always stated that a missing newline parameter has no action, e.g. newlines are newlines.

-- TWiki:Main.PeterThoeny - 2014-04-01

I tested the patch. Before the patch you got two line breaks as you reported in Item7476, after the patch you get one line break as expected. Do I miss something?

-- TWiki:Main.PeterThoeny - 2014-04-01

Item7476 is fixed (thanks!). As I stated above, the newly documented $br variable for the SEARCH newline parameter did not work in my testing.

-- TWiki:Main.DavidDAllen - 2014-04-01

Confirmed.

-- TWiki:Main.PeterThoeny - 2014-04-01

This is now fixed. I changed the summary to reflect the nature of this new mini-feature.

-- TWiki:Main.PeterThoeny - 2014-04-01

ItemTemplate
Summary Add $br to newline and separator parameter of SEARCH
ReportedBy TWiki:Main.DavidDAllen
Codebase ~twiki4, 6.0.0
SVN Range TWiki-6.0.1-trunk, Sat, 22 Mar 2014, build 27164
AppliesTo Engine
Component

Priority Enhancement
CurrentState Closed
WaitingFor

Checkins TWikirev:27248 TWikirev:27249 TWikirev:27250 TWikirev:27251
TargetRelease patch
ReleasedIn 6.0.1
Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2014-10-06 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback