• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7602: TWiki::Net::sendEmail() with improved error handling

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   patch 6.0.2

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

TWiki::Net::sendEmail() takes the second argument as the number tries. If it's 5, 5 tries happen before the function gives up. But in the code, the term "retries" is used instead of tries, which is confusing. So switching from retries to tries in variable names and comments is desirable.

After a send failure, the function waits for retry. With the current implementation, the wait happens even after the last try, which is time waste.

After the number of tries, a message saying "Too many failures sending mail" is shown. This happens even if the number of tries is one. It doesn't sound right to call one failure "too many failures" though technically correct.

-- TWiki:Main/HideyoImazu - 2015-01-08

ItemTemplate
Summary TWiki::Net::sendEmail() with improved error handling
ReportedBy TWiki:Main.HideyoImazu
Codebase ~twiki4, 6.0.1
SVN Range TWiki-6.0.1-trunk, Sun, 14 Dec 2014, build 28541
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:28587 TWikirev:28588
TargetRelease patch
ReleasedIn 6.0.2
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2016-01-22 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback