I just got this message on an edit conflict:
They have been editing for 4 minutes 38 seconds and their lease is still active for another 55 minutes 22 seconds.
Nobody cares about number of seconds to wait. I suggest to change that to:
They have been editing for 4 minutes and their lease is still active for another 55 minutes.
--
PTh
aaaaaargh - i don't care about them being there - but i sure don't want to be told they have been editing for 0 minutes etc...
-- SD
How about:
$time = 60 if( $time < 60);
# unit seconds
--
PTh
Some might care that the count down does not decrease when they try again if we hide seconds.
If you think it is wordy, try shortening it to '4min 55s'
Frankly, given everything else, I don't think this conv. is worth having. I suggest you discard it.
--
MC
Good idea to display in minutes unless the time is less than 1 minute and seconds are displayed.
Sure there will be some people that don't see the time decrease, but I find this a good solution for all other 99.99%.
AC
righto - i'm tossing this on the enhancement pile - too pointless for me to look into - i've enough of a hard time concentrating on the real bugs while i'm sick -- SD
Undeferred, post Dakar
CC
Waste of time. Discarded.
CC
I don't agree this is a waste of time, but it
is a detail. If there was a label Low Enhancement I would use that. Using Low now.
In Edit.pm:
# The lease is active
$def = 'lease_active';
$past = TWiki::Time::formatDelta(
$t - $lease->{taken}, $session->{i18n} );
$future = TWiki::Time::formatDelta(
$lease->{expires} - $t, $session->{i18n} );
Should become something like this:
# The lease is active
$def = 'lease_active';
my $pastseconds = $t - $lease->{taken};
if ($pastseconds > 60) $pastseconds %= 60;
my $futureseconds = $lease->{expires} - $t;
if ($futureseconds > 60) $futureseconds %= 60;
$past = TWiki::Time::formatDelta(
$pastseconds, $session->{i18n} );
$future = TWiki::Time::formatDelta(
futureseconds, $session->{i18n} );
but I am afraid that
formatDelta
will just display 0 seconds.
So, add a parameter to
formatDelta
, like
round
?
AC