Item7799: TWiki with current Perl: Eliminate warnings

• Possible precedence issue with control flow operator at /linuxdevel/twiki/trunk/core/lib/TWiki/Attach.pm line 226.
  • This is somewhat serious: The line in question reads return $info->{attr} or " ";. This has always been equivalent to return $info->{attr}; because return has higher precendence than or. The warning came up in Perl 5.20.
  • Since this bad line has apparently been working for ages I'll simply drop the or clause.
  • Done in Rev. 30334. -- TWiki:Main/HaraldJoerg - 2017-05-26
• Useless use of greediness modifier '?' ... at trunk/core/lib/TWiki/Store/RcsLite.pm line 302.
  • Another new warning in Perl 5.20. I guess it slipped through since RcsLite is rarely used in production. I am using RcsLite quite regularly in my TWikis on Windows and haven't seen any bad effects, and I don't understand what the greediness modifier was supposed to do at all. Therefore I'll simply eliminate it.
  • Done in Rev. 30335. -- TWiki:Main/HaraldJoerg - 2017-05-26
• Unescaped left brace in regex is deprecated, passed through in regex; ... at CommentPlugin/CommentPluginTests.pm line 224 , 226
  • A special case since the left brace comes in through a variable, so replacing { with \{ isn't applicable. The method \Q$var\E works.
    • Done in Rev. 30327 -- TWiki:Main/HaraldJoerg - 2017-05-26
• TWiki::I18N::_normalize_language_tag should not issue a warning if there's no predefined language
  • Done in Rev. 30336. -- TWiki:Main/HaraldJoerg - 2017-05-26

-- TWiki:Main/HaraldJoerg - 2017-04-10