• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

In view.pattern.tmpl's %TMPL:DEF{"topicactionbuttons"}%, rather than having repeated:

%TMPL:P{context="inactive" then="inactive_edit" else="active_edit"}%%TMPL:P{"sep"}%%TMPL:P{context="inactive" then="inactive_attach" else="active_attach"}%%TMPL:P{context="inactive" then="inactive_more" else="active_more"}%

How about e.g.

%TMPL:P{"activatable_edit"}%%TMPL:P{"activatable_attach"}%%TMPL:P{"activatable_more"}%

Where:

%TMPL:DEF{"active_more"}%<a href="%SCRIPTURLPATH%/oops%SCRIPTSUFFIX%/%WEB%/%TOPIC%?template=oopsmore&param1=%MAXREV%&param2=%CURRREV%" title='%_{"Delete or rename this topic; set parent topic; view and compare revisions"}%' accesskey="M" rel="nofollow">%_{"&More topic actions"}%</a>%TMPL:END%
%TMPL:DEF{"inactive_more"}%<span class="patternButton"><strike>%_{"More topic actions..."}%</strike></span>%TMPL:END%
%TMPL:DEF{"activatable_more"}%%TMPL:P{context="inactive" then="inactive_more" else="active_more"}%%TMPL:END%

This would be a lot terser and easier to grok. Trying to move Edit to next to Raw View is really painful given the complexity of this file.

If you like this approach I'll try to make time to implement it.


All refactoring is welcome. Make sure you have the latest version smile

Point of attention: the separators in the bottom action bar that are not in the tab buttons at the top.

AC

Okay, done.

Committed revision 7263.

Note that Edit is next to View Raw when WysiwygPlugin is enabled. I left the existing Compose nonclamature despite my preference of using Edit. I guess both will need to stay until we sort out switching to/from raw editor inside kupu.

If you don't like this set up then please re-edit the template rather than rolling it back. I refactored the template so it is much easier to read.

activatable_switchable_edit turns from Edit to Compose when WysiwygPlugin is installed
activatable_combo_edit (not used) retains the Edit next to Compose pair.

If you want the old behaviour, alter the use of switchable to combo in the two sets of buttons:

  • toolbar_buttons (at the top)
and
  • topicactionbuttons (at the bottom)

MC

If it's done, it's presumably closed. CC

ItemTemplate
Summary Refactor view.pattern.tmpl
ReportedBy MartinCleaver
AppliesTo Engine
Priority Low
CurrentState Closed
WaitingFor

Checkins 7263
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2005-11-06 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2020 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback