We have: TWiki/data/PatternSkin.txt and in twikiplugins/PatternSkin/data/PatternSkin.txt and they are out of tune.
Should PatternSkin be like other plugins and have the topic in the twikiplugins directory?
AC
That makes sense provided that the build works as expected.
--
PTh
Sure does. And this is a necessary thing to do.
CC
OK, everything is now in twikiplugins/PatternSkin (SVN 7514).
And now? Can I delete the old files? How to not break things?
AC
Er, no Arthur, that not right, yet.
Well, OK, there's confusion as to whether a skin is a Contrib, Plugin or Add-on as far as the build goes, but what's there right now doens't make the cut when build runs.
But lets make you the
Poster Boy for skins.
You've got the
data/
,
lib/
and
templates/
. You now need a
lib/
. Make a
lib/TWiki/Contrib/PatternSkin/
and move the
DEPENDENCIES
and
MANIFEST
there, and put a copy of the
build.pl
that other Contrib's use there - it doens't have to be customized.
Now, the
Poster Boy stuff. You need a piece of code, a very small piece in
PatterSkin.pm
, and that needs to be in the MANIFEST as well.
All the code
has to do is declare a couple of variables - the revision. If you want to put extra descriptive stuff in there too, great.
Use
TipsContrib/
as an example.
Now, to be fair, TWiki/InstalledPlugins only lists the revisions and descriptions for the Plugins. Perhaps we need something similar for the Contribs.
--
AJA
I have followed your instructions: SVN 7541, 7542, 7543.
I think it should be tested first to build without bugs before removing pattern skin from the old locations.
AC
I'm getting tired of updating all files in 2 locations. What can I do now before deleting all old pattern skin files?
AC
Closed with
Item1112. --
AC
i removed the files from
tools/MANIFEST
in SVN:7978 --
WN