• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

The original version of a TWiki topic is lost.

It is easy to reproduce.

Open a topic in the TWiki web. It must be one that does not yet have a ,v file.

Edit the topic adding some lines and changing some variable value.

Save.

You now have a R2 and R1.

BUT.

R1 is identical to R2. Your original version is lost forever.

This is very bad when you edit TWikiPreferences, WebPreferences, A plugin page etc. You have always been able to count on being able to go back to any previous version. Now your original default settings are gone.

-- TWiki:Main.KennethLavrsen 10 Nov 2005


OK, this is very not good. Changed to a requirement. CC
Hmm. I just tried this, and it works perfectly. Are yu sure you have write access to the directory? Can you list the ,v file here please?

CC


Uploaded both topic and ,v file which I had to rename to _v to be able to upload it.

And yes. Apache user is owner of the directory and files. And rwx.

Kenneth


This is the same behaviour as Cairo (that's not saying it's right, just that the behaviour is the same.

Reclassified as Enhancement.

CC

Who is actioning on this?

-- PTh

Crawford is right, Cairo has this bug too. Spec how TWiki is supposed to act:

  • On topic save and file attach, if the ,v file does not exist:
    • Checkin r1 with the current topic/file content, timestamp of file and UnknownUser
    • Checkin r2 with modified content as usual (current time, current user)

-- PTh

Actually, it would be a real treat if this behaviour was generalized, so it was not restricted to the first save without a ,v-file, but this was checked at all saves. Meaning, that if current (topic|attachment) is not in line with latest version in its ,v-file, save current version as well. (Pre-edit version with regards to topics, existing version with regards to attachments) .

Not that I expect to use this a lot, but if we're going to touch it anyway, it would be an extra feature if TWiki never "overwrites" content (even though it didn't place it there itself), but only saves this as an intermediate version beloning to UnknownUser as descriped in spec above.

This is purely WIBNIF and only for peace-of-mind, seeing that we're possibly about to update functionality anyhow.

BTW, this feature would probably need some aligment with TWiki:Codev.AutomaticAttachments.

SP

By some miracle this bug item is actually fixed.

If I delete the ,v file the last topic version is shown and it seems all the old versions are there. That is OK with me.

When I open the topic and save it I get a rev 2.

The revision 1 is the previous version incl the old version number. I find that perfectly OK also. It is an error situation to delete the ,v files. And the current behavour seems the best we can do when the history is lost. We maintain the previous version as it was and we add a new as revision 2.

When we distribute plugin topics and there may not be a ,v file all is also fine. We then have a rev 1 and rev 2 after the first save. That is all as I would want it.

It has been closed sometimes between I reported it and 4.0.5 so I set it to closed.

KJL

ItemTemplate
Summary Versioning broken on new virgin topics
ReportedBy KennethLavrsen
Codebase

SVN Range

AppliesTo Engine
Component

Priority Enhancement
CurrentState Closed
WaitingFor

Checkins

TargetRelease n/a
Topic attachments
I Attachment History Action Size Date Who Comment
Texttxt WelcomeGuest.txt r1 manage 5.0 K 2005-11-10 - 08:39 KennethLavrsen  
Unknown file formattxt_v WelcomeGuest.txt_v r1 manage 5.1 K 2005-11-10 - 08:40 KennethLavrsen  
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r9 - 2006-12-07 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2020 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback