In the Progress of tweaking TWiki to be installed as RPM in a clean way and customizing it for our needs I find some issues. One is the follow.
It is not that buggy but it is a completely wast of resources and a pain in the
eyes. Sorting keys of a hash to loop over it and finally put the result back to
another hash (which makes the order explicit unsorted!)...
Well, there are bugs which are more important but this just hurts in the eyes.
diff -Nur TWiki-4.1.2.orig/lib/TWiki/UI/Manage.pm TWiki-4.1.2/lib/TWiki/UI/Manage.pm
--- TWiki-4.1.2.orig/lib/TWiki/UI/Manage.pm 2007-03-03 15:45:57.000000000 +0100
+++ TWiki-4.1.2/lib/TWiki/UI/Manage.pm 2007-12-12 11:29:13.000000000 +0100
@@ -490,12 +490,7 @@
# and build up a hash containing permissions and lock info.
$refs0 = getReferringTopics( $session, $oldWeb, undef, 0 );
$refs1 = getReferringTopics( $session, $oldWeb, undef, 1 );
- foreach my $ref (sort keys %$refs0) {
- $refs{$ref} = $refs0->{$ref};
- }
- foreach my $ref (sort keys %$refs1) {
- $refs{$ref} = $refs1->{$ref};
- }
+ %refs = (%$refs0, %$refs1);
$webTopicInfo{referring}{refs0} = $refs0;
$webTopicInfo{referring}{refs1} = $refs1;
--
KlausEthgen - 21 Apr 2008
interesting, your change is what is already in the MAIN branch, it wasn't in the 4.2 branch - I've commited it thanks
--
SvenDowideit - 22 Apr 2008